Refer to jfrog container instead of docker hub (Daml Shell image) #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmackay
approved these changes
Aug 1, 2024
carrielaben-da
approved these changes
Aug 1, 2024
dylant-da
approved these changes
Aug 26, 2024
| @@ -50,11 +50,11 @@ Running Daml Shell | |||
| ================== | |||
|
|
|||
| You can run Daml Shell from a ``jar`` artifact or from a ``Docker`` | |||
| image. See the Release Notes for download instructions. | |||
| image. See the Release Notes for download instructions. | |||
There was a problem hiding this comment.
Like Carrie, I'm not sure what release notes refers to here, a link would be useful - I don't see any download instructions on the Github releases if that's where it's supposed to link to?
|
|
||
| .. code-block:: sh | ||
|
|
||
| docker run -it --net host docker.io/digitalasset/daml-shell:<version-tag> # change --net host if desired | ||
| docker run -it --net host digitalasset-docker.jfrog.io/daml-shell:<version-tag> # change --net host if desired |
There was a problem hiding this comment.
An example URL for a specific tag would be useful - it's not obvious where the user should type daml-shell:v0.1.4 or daml-shell:0.1.4 here.
|
|
||
| .. code-block:: sh | ||
|
|
||
| docker run -it --net host docker.io/digitalasset/daml-shell:<version-tag> # change --net host if desired | ||
| docker run -it --net host digitalasset-docker.jfrog.io/daml-shell:<version-tag> # change --net host if desired |
There was a problem hiding this comment.
I can't test the command here actually works - my docker credentials + my artifactory credentials are presumably not sufficient. It would likely be good to add a sub-section on what an authentication failure looks like and how to remedy it, since the error I get:
docker: Error response from daemon: Head "https://digitalasset-docker.jfrog.io/v2/daml-shell/manifests/v0.1.4": unknown: Authentication is required.
is not terribly informative
iggy-da
force-pushed
the
2024-08-01-daml-shell
branch
from
527857f
to
889ae3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.