Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add batch daml example as a code snippet #770

Merged
merged 20 commits into from
Oct 31, 2024
Merged

Add batch daml example as a code snippet #770

merged 20 commits into from
Oct 31, 2024

Conversation

JoaoSa-da
Copy link
Contributor

No description provided.

@JoaoSa-da JoaoSa-da requested review from a team as code owners July 25, 2024 10:49
carrielaben-da
carrielaben-da approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@carrielaben-da carrielaben-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for immediate use but I'd like to take a stab at reorganizing the information to be a bit clearer in the future.

docs/2.10.0/docs/canton/usermanual/performance.rst Outdated Show resolved Hide resolved
docs/2.10.0/docs/canton/usermanual/performance.rst Outdated Show resolved Hide resolved
docs/2.10.0/docs/canton/usermanual/performance.rst Outdated Show resolved Hide resolved
docs/2.10.0/docs/canton/usermanual/performance.rst Outdated Show resolved Hide resolved
docs/2.10.0/docs/canton/usermanual/performance.rst Outdated Show resolved Hide resolved
docs/2.10.0/docs/canton/usermanual/performance.rst Outdated Show resolved Hide resolved
docs/2.10.0/docs/canton/usermanual/performance.rst Outdated Show resolved Hide resolved
docs/3.1/docs/canton/usermanual/performance.rst Outdated Show resolved Hide resolved
docs/3.1/docs/canton/usermanual/performance.rst Outdated Show resolved Hide resolved
docs/2.10.0/docs/canton/usermanual/performance.rst Outdated Show resolved Hide resolved
@dylant-da
Copy link
Contributor

@JoaoSa-da is this PR still open? I see you didn't stage Batching.daml, so I assume that's blocking the CI build.

dylant-da
dylant-da approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@dylant-da dylant-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carrie covered my questions - looks good to me, aside from what she's mentioned, and build issues that look like a simple fix

@JoaoSa-da
Copy link
Contributor Author

@dylant-da yes it is failing because it cannot find this file. What do you mean by staging Batching.daml. Do I need to do something in particular in the daml repo?

@JoaoSa-da JoaoSa-da merged commit 558fe12 into main Oct 31, 2024
1 check passed
@JoaoSa-da JoaoSa-da deleted the i20418-add-batching-daml-example branch October 31, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylant-da dylant-da dylant-da approved these changes

@carrielaben-da carrielaben-da carrielaben-da approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoaoSa-da @dylant-da @carrielaben-da