[DO NOT MERGE] GetUpdatesRequest #20000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Congratulations on being the 20000th issue on the Daml repo! 🎉 |
samuel-williams-da
approved these changes
Sep 24, 2024
atriantafyllos-da
force-pushed
the
atriantafyllos/get-updates-request
branch
from
acc821f
to
3b907ac
Compare
* Drop unused NewVariant errors, add NotAtEnd errors, improve messages * Refactor error printing slightly * Update error message expectations in lsp-tests & damlc-upgrades * Add metadata to pkg IDs & drop upgrading/upgraded in upgrade err msgs * Replace "Variant" with "Constructor" where appropriate * lint * Adjust filepaths, expectations for Variant -> Constructor rename * Fixes for field names and test expectations given added metadata * Increase grpc message max log length * lint * Move & rename PkgIdWithMeta, make name/version non-optional * Use shared variable instead of calling PkgIdWithNameAndVersion thrice * lint
* Drop unused NewVariant errors, add NotAtEnd errors, improve messages * Refactor error printing slightly * Update error message expectations in lsp-tests & damlc-upgrades * Add metadata to pkg IDs & drop upgrading/upgraded in upgrade err msgs * Replace "Variant" with "Constructor" where appropriate * lint * Adjust filepaths, expectations for Variant -> Constructor rename * Fixes for field names and test expectations given added metadata * Increase grpc message max log length * lint * Move & rename PkgIdWithMeta, make name/version non-optional * Use shared variable instead of calling PkgIdWithNameAndVersion thrice * lint
atriantafyllos-da
force-pushed
the
atriantafyllos/get-updates-request
branch
from
3b907ac
to
d015b22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.