Update MissingPackage error to allow reporting by package name
#19972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael-speyer-da
force-pushed
the
rls/errors-with-package-ref-a
branch
from
e8b34a3
to
e11d5ef
Compare
| @@ -86,7 +86,7 @@ final class ValueEnricher( | |||
|
|
|||
| private[this] def handleLookup[X](lookup: => Either[LookupError, X]) = lookup match { | |||
| case Right(value) => ResultDone(value) | |||
| case Left(LookupError.MissingPackage(pkgId, context)) => | |||
| case Left(LookupError.MissingPackage(PackageRef.Id(pkgId), context)) => | |||
There was a problem hiding this comment.
Case where we need different handling for missing package by id vs name, and can distinguish easily enough.
Comment on lines
-50
to
-51
| final case class PackageWithName(packageName: PackageName) extends Reference { | ||
| override def pretty: String = s"package $packageName" |
There was a problem hiding this comment.
Replaced with Package(PackageRef.Name(...))
| def apply(packageRef: Ref.PackageRef): MissingPackage = | ||
| MissingPackage(packageRef, language.Reference.Package(packageRef)) | ||
|
|
||
| def apply(packageId: Ref.PackageId): MissingPackage = apply(Ref.PackageRef.Id(packageId)) |
There was a problem hiding this comment.
Keep overloads for building with a PackageId for convenience and compatibility.
remyhaemmerle-da
approved these changes
Sep 25, 2024
raphael-speyer-da
force-pushed
the
rls/errors-with-package-ref-a
branch
from
e11d5ef
to
e5a1e3c
Compare
raphael-speyer-da
force-pushed
the
rls/errors-with-package-ref-a
branch
from
e5a1e3c
to
33fdc75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the participant, the handling of a command which contains a template id whose package id is not known should be the same, irrespective of whether the template id specified the package with a package id or a package name. From that point of view, it makes sense to handle both cases with the same error.
If the
MissingPackagetype contained aPackageRefrather than aPackageIdit could make this more uniform, and cases which did need to distinguish could still pattern match on the subtype ofPackageRef, as needed.