Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to LF1.17, Support external daml-sdk tarball #1246

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

samuel-williams-da
Copy link
Collaborator

@samuel-williams-da samuel-williams-da commented Oct 31, 2024

This PR adds support for an external daml-sdk tarball (i.e. generated by the daml repo as 0.0.0), via an optional field in the root daml.yaml

It also updates every package to LF1.17, enables the correct flags, and moves to daml-script-beta.

This work has uncovered a bug in daml-script and daml-script-beta, which were fixed by this daml pr
This PR uses a snapshot that includes that fix.

@samuel-williams-da
Copy link
Collaborator Author

Note that the upgrade to daml-script-beta is optional here, but is the preferred daml-script when upgrades is enabled. If this causes issues with generated docs and such, we can revert that part.

@samuel-williams-da samuel-williams-da marked this pull request as ready for review November 7, 2024 09:34
@samuel-williams-da samuel-williams-da requested a review from a team as a code owner November 7, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants