NonEmptyList copy-constructors accept Collection #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of requiring a List, which is unnecessary strict. This aligns with the JDK copy constructors for lists: public ArrayList(Collection<? extends E> c) https://docs.oracle.com/javase/8/docs/api/java/util/ArrayList.html#ArrayList-java.util.Collection- List.copyOf https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/List.html#copyOf(java.util.Collection)
Less specific types in method parameters is not binary backwards compatible :( The methods can and should be deleted for a new major-release.
5 tasks
runeflobakk
commented
Feb 20, 2024
| * or {@link Optional#empty()} if the given collection is empty | ||
| */ | ||
| static <E> Optional<NonEmptyList<E>> copyOf(Collection<E> collection) { | ||
| return of(new ArrayList<>(collection)); |
There was a problem hiding this comment.
Using copy constructor of ArrayList from the JDK instead of the oh-so-fancy firstOf(list).map(...) previously used for copyOf(List).
draperunner
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring a List, which is unnecessary strict. This aligns with the JDK copy constructors for lists:
Keeping around the constructors accepting Lists, because of backwards compatibility.