story/VOGRE-16

[rajvi-patel-22]

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

• I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
• I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
• I do not have any sysout statements in my code or commented out code that isn’t needed anymore
• I am not reformatting any files in the wrong format or without cause.
• I am not changing file encoding or line endings to something else than UTF-8, LF
• My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
• I have added Javadoc/documentation where appropriate
• I have added test cases where appropriate
• I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

Fix Docker setup: VOGRE-16
Vogon needs to be run through supervisor

Are there any other pull requests that this one depends on?

Anything else the reviewer needs to know?

[jdamerow]

Is this actually working? It stopped working for me for some reason.

[rajvi-patel-22]

I guess there was an extra space after the APP_ROOT variable, which I have fixed:
APP_ROOT= -> APP_ROOT=

[jdamerow]

Let's use the line from the updated development version:
source .env_app

[jdamerow]

this does not seem right. That's the dev startup script, right? So it will still run the dev server. Instead Django should be run with Guniconr and supervisor would start gunicorn. It should look somewhat like this probably:
https://github.com/diging/amphora-docker/tree/main/scripts
(without the celery part and there might be updates to it). Maybe google gunicorn, django, and supervisor and see if you can find an update ot date example.

[jdamerow]

Let's use the line from the updated development version:
source .env_app

[jdamerow]

log-file should log to a file.

[jdamerow]

supervisor should be installed as a service so you can start it as such (systemctl start supervisor I believe)

[jdamerow]

also there are conflicts

[diging-jenkins]

Can one of the admins verify this patch?