-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
story/VSPC-242 #345
Open
jophals
wants to merge
71
commits into
develop
Choose a base branch
from
story/VSPC-242
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
story/VSPC-242 #345
Changes from 68 commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
1f5cc4a
[story/VSPC-242]UI changes
swetalina-prusty25 ff64e16
[story/VSPC-242]create external link ajax call
swetalina-prusty25 4ae81d8
[story/VSPC-242]external link alert UI
swetalina-prusty25 0225cc2
[story/VSPC-242]Javascript
swetalina-prusty25 29725e7
[story/VSPC-242] Edit external link
swetalina-prusty25 954d2fb
[story/VSPC-242] drawlink
swetalina-prusty25 c165ac5
[story/VSPC-242]Entity
swetalina-prusty25 983cf14
[story/VSPC-242]Entity
swetalina-prusty25 ef6194e
[story/VSPC-242]Factory Class
swetalina-prusty25 b4e6a32
[story/VSPC-242]Repo
swetalina-prusty25 e079705
[story/VSPC-214] create external link
swetalina-prusty25 bc6c35a
[story/VSPC-242] Controller
swetalina-prusty25 a4106ee
[story/VSPC-242] updated controller
swetalina-prusty25 800e222
[story/VSPC-242]create link
swetalina-prusty25 91257f7
[story/VSPC-242]Create and display link
swetalina-prusty25 fe88ded
[story/VSPC-242]Delete link
swetalina-prusty25 a5f4d2c
[story/VSPC-242]update and delete
swetalina-prusty25 26406a0
[story/VSPC-242]controller
swetalina-prusty25 93e1bae
[story/VSPC-242]set positions
swetalina-prusty25 726ca20
[story/VSPC-242] Java script
swetalina-prusty25 d49a364
[story/VSPC-242]Utility js functions
swetalina-prusty25 158ac5a
[story/VSPC-242]External link editable
swetalina-prusty25 3713c45
[story/VSPC-242] Text area function
swetalina-prusty25 d14bdcb
[story/VSPC-242]Buttons ajax call
swetalina-prusty25 89cae0d
[story/VSPC-242] Ajax method for create link
swetalina-prusty25 bc9c564
[story/VSPC-242]Ajax method for edit external link
swetalina-prusty25 62906bf
[story/VSPC-242] Delete button java script
swetalina-prusty25 04f9c0a
[story/VSPC-242] Delete and cancel button
swetalina-prusty25 598e51a
[story/VSPC-242] Fixing front end issue
swetalina-prusty25 d5efaa7
[story/VSPC-242] Alert issue fixed
swetalina-prusty25 4198951
[story/VSPC-242] Area for link working
swetalina-prusty25 73e38f6
[story/VSPC-242] model
swetalina-prusty25 bd001e0
[story/VSPC-242] External link storing
swetalina-prusty25 3c7e352
[story/VSPC-242] Manager methods
swetalina-prusty25 49628c7
[story/VSPC-242] modified entinty
swetalina-prusty25 2a74b83
[story/VSPC-242] Repository
swetalina-prusty25 9b5d030
[story/VSPC-242]Display factors
swetalina-prusty25 41a805a
[story/VSPC-242]Manager methods
swetalina-prusty25 c29fc77
[story/VSPC-242]Display id
swetalina-prusty25 d7b3078
[story/VSPC-242] Edit link
swetalina-prusty25 6a720f1
[story/VSPC-242] success
swetalina-prusty25 4b68cbc
[story/VSPC-242] Edit issue
swetalina-prusty25 c1df0ad
[story/VSPC-242]Unit test
swetalina-prusty25 9f6ac39
[story/VSPC-242]Created slide display manager
swetalina-prusty25 7d1817d
[VSPC-242]Test and Template issue
swetalina-prusty25 b580b60
[story/VSPC-242] Updated the entity
swetalina-prusty25 0d0fcfe
[story/VSPC-242] slide display
swetalina-prusty25 20c23d9
[story/VSPC-242]Slide Display entity
swetalina-prusty25 2592d81
[story/VSPC-242] factory
swetalina-prusty25 95d5b40
[story/VSPC-242]validation and store
swetalina-prusty25 64df795
[story/VSPC-242]test for factory and update
swetalina-prusty25 a2e534e
[story/VSPC-242]Update link test cases
swetalina-prusty25 180eae7
[story/VSPC-242]Delete testcase
swetalina-prusty25 79259ed
[story/VSPC-242]display api
swetalina-prusty25 0a5c62f
Merge branch 'develop' of https://github.com/diging/virtual-spaces-2.…
jophals 99d41ec
[fixed creation, editing, and deletion of slide external links; clean…
jophals 7dd2a82
[VSPC-242]Fixed code factor issues
jophals 1888c1c
[VSPC-242] more CodeFactor indentation fixes
jophals 36c2f5e
[VSPC-242] removed some unnecessary classes, methods, repositories, e…
jophals b4bf072
[VSPC-242] fixed findBySlide query
jophals 9a3567a
[VSPC-242] fixed SlideExternalLink repo, unnecessary spacing, imports,
jophals fbb4f6e
made PR fixes; tried to restore some files to previous state
jophals 5cb787e
Merge branch 'develop' into story/VSPC-242
jophals 5144ae0
Executed suggested PR changes except the changes for
jophals 204c91b
[VSPC-242] implemented additional PR change like DeleteLinkController
jophals 23b575a
[VSPC-242] additional PR comment fixes
jophals 13e9bd5
Merge branch 'story/VSPC-242' of https://github.com/diging/virtual-sp…
jophals b12f048
Merge branch 'develop' into story/VSPC-242
jophals 293df7a
[VSPC-242] implemented PR changes: fixed naming issue with link
jophals f0a0aa3
Merge branch 'story/VSPC-242' of https://github.com/diging/virtual-sp…
jophals 9d24363
[story/VSPC-242] link controller name fix
jophals File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
17 changes: 17 additions & 0 deletions
17
vspace/src/main/java/edu/asu/diging/vspace/core/data/SlideExternalLinkRepository.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
package edu.asu.diging.vspace.core.data; | ||
|
||
import java.util.List; | ||
|
||
import org.javers.spring.annotation.JaversSpringDataAuditable; | ||
import org.springframework.data.repository.PagingAndSortingRepository; | ||
import org.springframework.stereotype.Repository; | ||
|
||
import edu.asu.diging.vspace.core.model.IExternalLinkSlide; | ||
import edu.asu.diging.vspace.core.model.impl.ExternalLinkSlide; | ||
|
||
@Repository | ||
@JaversSpringDataAuditable | ||
public interface SlideExternalLinkRepository extends PagingAndSortingRepository<ExternalLinkSlide, String> { | ||
|
||
public List<IExternalLinkSlide> findBySlide_Id(String slideId); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,4 +7,4 @@ public interface IExternalLinkFactory { | |
|
||
IExternalLink createExternalLink(String title, ISpace space); | ||
|
||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
vspace/src/main/java/edu/asu/diging/vspace/core/model/IExternalLinkSlide.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package edu.asu.diging.vspace.core.model; | ||
|
||
public interface IExternalLinkSlide{ | ||
|
||
String getId(); | ||
|
||
void setId(String id); | ||
|
||
ISlide getSlide(); | ||
|
||
void setSlide(ISlide slide); | ||
|
||
String getExternalLink(); | ||
|
||
void setExternalLink(String externalLink); | ||
|
||
String getLabel(); | ||
|
||
void setLabel(String label); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
vspace/src/main/java/edu/asu/diging/vspace/core/model/impl/ExternalLinkSlide.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
package edu.asu.diging.vspace.core.model.impl; | ||
|
||
import javax.persistence.Entity; | ||
import javax.persistence.GeneratedValue; | ||
import javax.persistence.Id; | ||
import javax.persistence.JoinColumn; | ||
import javax.persistence.ManyToOne; | ||
|
||
import org.hibernate.annotations.GenericGenerator; | ||
import org.hibernate.annotations.Parameter; | ||
|
||
import edu.asu.diging.vspace.core.model.IExternalLinkSlide; | ||
import edu.asu.diging.vspace.core.model.ISlide; | ||
|
||
@Entity | ||
jdamerow marked this conversation as resolved.
Show resolved
Hide resolved
|
||
public class ExternalLinkSlide extends VSpaceElement implements IExternalLinkSlide { | ||
|
||
@Id | ||
@GeneratedValue(generator = "extlinkslide_id_generator") | ||
@GenericGenerator(name = "extlinkslide_id_generator", | ||
parameters = @Parameter(name = "prefix", value = "EXLS"), | ||
strategy = "edu.asu.diging.vspace.core.data.IdGenerator") | ||
private String id; | ||
|
||
@ManyToOne(targetEntity=Slide.class) | ||
@JoinColumn(name="slide_id", nullable=false) | ||
private ISlide slide; | ||
|
||
private String externalLink; | ||
|
||
private String label; | ||
|
||
@Override | ||
public String getId() { | ||
return id; | ||
} | ||
|
||
@Override | ||
public void setId(String id) { | ||
this.id = id; | ||
} | ||
|
||
@Override | ||
public ISlide getSlide() { | ||
return slide; | ||
} | ||
|
||
@Override | ||
public void setSlide(ISlide slide) { | ||
this.slide = slide; | ||
} | ||
|
||
@Override | ||
public String getExternalLink() { | ||
return externalLink; | ||
} | ||
|
||
@Override | ||
public void setExternalLink(String externalLink) { | ||
this.externalLink = externalLink; | ||
} | ||
|
||
@Override | ||
public String getLabel() { | ||
return label; | ||
} | ||
|
||
@Override | ||
public void setLabel(String label) { | ||
this.label = label; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
vspace/src/main/java/edu/asu/diging/vspace/core/services/ISlideExternalLinkManager.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package edu.asu.diging.vspace.core.services; | ||
|
||
import edu.asu.diging.vspace.core.model.IExternalLinkSlide; | ||
|
||
public interface ISlideExternalLinkManager { | ||
|
||
IExternalLinkSlide getLink(String externalLinkID); | ||
|
||
IExternalLinkSlide createExternalLink(String title, String url, String slideId); | ||
|
||
IExternalLinkSlide updateExternalLink(String title, String url, String id); | ||
|
||
void deleteLink(String linkId); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary?