Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story/q20 16 #32

Open
wants to merge 338 commits into
base: develop
Choose a base branch
from
Open

Story/q20 16 #32

wants to merge 338 commits into from

Conversation

ShivaniYerram
Copy link
Contributor

@ShivaniYerram ShivaniYerram commented Apr 1, 2023

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

(you can copy the ticket if it hasn't changed)

Q20-16 There should be a page that allows a user to explore all mapped triples of a collection.

Anything else the reviewer needs to know?

... describe here ...
This branch has code from story/Q20-19 as well. So, that must be merged first before this

MaulikLim and others added 30 commits November 3, 2021 16:53
@jdamerow
Copy link
Member

The tests don't all run.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project quadriga: Compilation failure
[ERROR] /var/lib/jenkins/workspace/quadriga2.0_deploy_on_pr_to_review/quadriga/src/test/java/edu/asu/diging/quadriga/core/service/impl/CollectionManagerImplTest.java:[172,68] no suitable method found for thenReturn(no arguments)
[ERROR] method org.mockito.stubbing.OngoingStubbing.thenReturn(edu.asu.diging.quadriga.core.model.Collection) is not applicable
[ERROR] (actual and formal argument lists differ in length)
[ERROR] method org.mockito.stubbing.OngoingStubbing.thenReturn(edu.asu.diging.quadriga.core.model.Collection,edu.asu.diging.quadriga.core.model.Collection...) is not applicable
[ERROR] (actual and formal argument lists differ in length)
[ERROR] -> [Help 1]

@jdamerow jdamerow closed this Apr 30, 2024
# Conflicts:
#	quadriga/pom.xml
#	quadriga/src/main/java/edu/asu/diging/quadriga/core/model/Collection.java
#	quadriga/src/main/java/edu/asu/diging/quadriga/core/service/CollectionManager.java
#	quadriga/src/main/java/edu/asu/diging/quadriga/core/service/impl/EventGraphServiceImpl.java
#	quadriga/src/main/java/edu/asu/diging/quadriga/core/service/impl/MappedTripleGroupServiceImpl.java
#	quadriga/src/main/java/edu/asu/diging/quadriga/web/DisplayCollectionController.java
# Conflicts:
#	quadriga/pom.xml
#	quadriga/src/main/java/edu/asu/diging/quadriga/core/conceptpower/model/CachedConcept.java
#	quadriga/src/main/java/edu/asu/diging/quadriga/core/conceptpower/model/ConceptType.java
#	quadriga/src/main/java/edu/asu/diging/quadriga/core/conceptpower/service/ConceptPowerConnectorService.java
#	quadriga/src/main/java/edu/asu/diging/quadriga/core/conceptpower/service/ConceptPowerService.java
#	quadriga/src/main/java/edu/asu/diging/quadriga/core/conceptpower/service/impl/ConceptPowerConnectorServiceImpl.java
#	quadriga/src/main/java/edu/asu/diging/quadriga/core/conceptpower/service/impl/ConceptPowerServiceImpl.java
#	quadriga/src/main/java/edu/asu/diging/quadriga/core/model/Collection.java
#	quadriga/src/main/java/edu/asu/diging/quadriga/core/service/CollectionManager.java
#	quadriga/src/main/java/edu/asu/diging/quadriga/core/service/impl/MappedTripleGroupServiceImpl.java
#	quadriga/src/main/java/edu/asu/diging/quadriga/web/DisplayCollectionController.java
#	quadriga/src/main/java/edu/asu/diging/quadriga/web/service/GraphCreationService.java
#	quadriga/src/main/java/edu/asu/diging/quadriga/web/service/impl/GraphCreationServiceImpl.java
#	quadriga/src/test/java/edu/asu/diging/quadriga/core/conceptpower/service/impl/ConceptPowerServiceImplTest.java
#	quadriga/src/test/java/edu/asu/diging/quadriga/web/service/impl/GraphCreationServiceImplTest.java
@pooja-thalur pooja-thalur reopened this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants