feat: update runtime.selectFile() to also return the file name #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
commented
Jan 7, 2025
Comment on lines
+49
to
+61
| function validateSelectedFileResult(value) { | ||
| if (!('path' in value && 'name' in value)) { | ||
| throw new Error('Value has invalid shape') | ||
| } | ||
|
|
||
| if (typeof value.path !== 'string') { | ||
| throw new Error('Value has invalid path field') | ||
| } | ||
|
|
||
| if (typeof value.name !== 'string') { | ||
| throw new Error('Value has invalid name field') | ||
| } | ||
| } |
There was a problem hiding this comment.
ideally would use valibot for this but I don't have bundling set up for the preload just yet so I think it would require some additional tooling work.
achou11
force-pushed
the
ac/runtime-select-file-expose-name
branch
from
d496f0d to
d363615
Compare
Merged
achou11
force-pushed
the
ac/runtime-select-file-expose-name
branch
from
d363615 to
1813e4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
runtime.selectFile()to return an object that contains the path and name of the selected file, as opposed to just the path. Informed by the needs of #55