Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create separate CI jobs for linting and testing #56

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Dec 11, 2024

Removes the linting step done in the npm test script. Instead, we run a separate CI job that handles just the linting checks so that it doesn't potentially interfere with tests running.

So now we have two jobs that run in our CI workflow:

  1. Lint - runs prettier + eslint checks
  2. Test - runs TypeScript checks + Vitest tests

Could potentially argue that TypeScript checks should live in (1), but I think it's fine to keep in (2) for now, which aligns with how we have other repos set up.

@achou11 achou11 requested a review from ErikSin December 11, 2024 22:59
@achou11 achou11 merged commit 7e62b7f into main Dec 11, 2024
2 checks passed
@achou11 achou11 deleted the ac/separate-lint-from-test branch December 11, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants