Skip to content

Commit

Permalink
use preStart hook instead of startLogic in custom forge plugin
Browse files Browse the repository at this point in the history
  • Loading branch information
achou11 committed Dec 17, 2024
1 parent 27d2948 commit 1c4e218
Showing 1 changed file with 14 additions and 25 deletions.
39 changes: 14 additions & 25 deletions forge.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ class CoMapeoDesktopForgePlugin extends PluginBase {
*/
getHooks() {
return {
preStart: [this.#initViteDevServer],
resolveForgeConfig: [this.#updatePackagerConfig],
postStart: [this.#hookViteDevServer],
prePackage: [this.#buildRender],
Expand All @@ -66,34 +67,22 @@ class CoMapeoDesktopForgePlugin extends PluginBase {
}

/**
* Starts the Vite dev server as part of the `forge start` command
*
* @type {PluginBase<{}>['startLogic']}
* @override
* @type {ForgeHookFn<'preStart'>}
*/
startLogic = async (_opts) => {
if (this.#viteDevServer) return false
#initViteDevServer = async (_opts) => {
if (this.#viteDevServer) return

return {
result: false,
tasks: [
{
title: 'Start Vite dev server',
task: async () => {
const server = await createServer({
configFile: RENDERER_VITE_CONFIG_PATH,
})
const server = await createServer({
configFile: RENDERER_VITE_CONFIG_PATH,
})

try {
await server.listen()
server.printUrls()
this.#viteDevServer = server
} catch {
console.log('Vite dev server already running.')
}
},
},
],
try {
await server.listen()
console.log('Started Vite dev server')
server.printUrls()
this.#viteDevServer = server
} catch {
console.log('Vite dev server already running.')
}
}

Expand Down

0 comments on commit 1c4e218

Please sign in to comment.