-
Notifications
You must be signed in to change notification settings - Fork 2
add cli #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cli #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, that is amazing! Thanks so much @Tieqiong .
Please could we have a few words in the readme with the new installation instructions so I can test it out? We can write more complete documentation into the docs after we do some testing, so keeping this brief for now.....
This needs a news, for sure, and it is failing CI. Does it need to be merged in order to pass CI or there is a tweak needed to the workflows?
@sbillinge our central release-script only knows to install dependencies from |
I didn't change how cmi get Now the "core" pack only has diffpy.utils, diffpy.srfit, diffpy.structure (and running dependencies packaging and PyYAML), and the "pdf" pack has diffpy.srreal and pyobjcrst. "tests" pack has all the testing stuff. "plotting" pack has all the plotting stuff. Run Now cmi has two "profiles": all and _tests. Run |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
===========================================
- Coverage 75.67% 50.00% -25.68%
===========================================
Files 3 2 -1
Lines 37 18 -19
===========================================
- Hits 28 9 -19
Misses 9 9 🚀 New features to boost your workflow:
|
I am super excited about this. Before I merge this I will do some testing on the version of diffpy.cmi on CF, just for a day or two, then I will merge this and test again. Then we can write te docs. I would like to write a new paper on this too. We can discuss what and when and who does what. I would like to position this as a more general regression engine rather than a local-structure thing, so I would like to do some examples where we use the modularity and flexibility more. |
let me update the CI for matrix before we merge it. |
macos-13 shell script support Use personal diffpy.utils tests source temporaly properly pass exit code for install cmd
@sbillinge ready for review! |
@sbillinge please check, thanks
This add nice cli features to diffpy.cmi, including:
One command to install optional dependencies and run workflows using mamba/conda:
diffpy.srreal
is included.One command to get information about your cmi:
It’s designed to be quiet by default, easy to use, and easy to extend.
Works on all platforms (hopefully)