[TG-21003] Add action per supported JDK version #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roxspring
force-pushed
the
roxspring/TG-21003-action-per-jdk
branch
2 times, most recently
from
4b8f191 to
dc045a4
Compare
TGWDB
approved these changes
Mar 11, 2024
Michael31416
approved these changes
Mar 11, 2024
QA notes:✅ JDK 8: ✅ JDK 11: ✅ JDK 17: JDK 21: |
yuzhong1
approved these changes
Mar 13, 2024
|
Agreed to defer JDK21 testing until TG-21006. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TG-21003
build.shto maintain JDK-specific actions and keep them in sync with the base action.QA
Added JDK-specific action variants (replace
@roxspring/TG-21003-action-per-jdkwith@mainonce merged):diffblue/cover-github-action@roxspring/TG-21003-action-per-jdk- Java 17 (but may change over time)diffblue/cover-github-action/jdk8@roxspring/TG-21003-action-per-jdk- Java 8diffblue/cover-github-action/jdk11@roxspring/TG-21003-action-per-jdk- Java 11diffblue/cover-github-action/jdk17@roxspring/TG-21003-action-per-jdk- Java 17diffblue/cover-github-action/jdk21@roxspring/TG-21003-action-per-jdk- Java 21 (only usable once JDK21 docker image is released)Changes committed that push the action variants out of sync results in CI failure:
