-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix publish workflow #8564
Merged
Merged
Fix publish workflow #8564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
fix-doc-build
branch
5 times, most recently
from
January 13, 2025 14:42
dc367b0
to
69f4f3b
Compare
tautschnig
requested review from
peterschrammel,
a team,
martin-cs,
kroening,
jimgrundy and
TGWDB
as code owners
January 13, 2025 14:43
For an unknown reason mermaid-filter (or, really, one of its dependencies) no longer work properly on Ubuntu 22.04. Using 24.04 addresses the problem. While at it, we also no longer need to overwrite the puppeteer dependency as mermaid-filter has updated its mermaid-cli dependency. No new release has been published just yet, so keep using the `git clone` approach from 71d3b4e rather than installing a release. Fixes: diffblue#8555
No need to mix package managers.
This is the version shipped with Ubuntu 24.04.
Doxygen 1.9.8 detects more problems than earlier versions did.
tautschnig
force-pushed
the
fix-doc-build
branch
from
January 13, 2025 14:56
69f4f3b
to
07cf0bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8564 +/- ##
===========================================
+ Coverage 78.79% 78.95% +0.15%
===========================================
Files 1730 1730
Lines 199160 198759 -401
Branches 18320 18314 -6
===========================================
Hits 156938 156938
+ Misses 42222 41821 -401 ☔ View full report in Codecov by Sentry. |
kroening
approved these changes
Jan 13, 2025
TGWDB
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an unknown reason mermaid-filter (or, really, one of its
dependencies) no longer work properly on Ubuntu 22.04. Using 24.04
addresses the problem. While at it, we also no longer need to overwrite
the puppeteer dependency as mermaid-filter has updated its mermaid-cli
dependency. No new release has been published just yet, so keep using
the
git clone
approach from 71d3b4e rather than installing arelease.
This entails updating the doxygen version we use by default, so please review commit-by-commit.