-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
line number for files with no newline #8558
Conversation
3e90cae
to
e67da47
Compare
cc07d16
to
6ee9f5b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8558 +/- ##
========================================
Coverage 79.63% 79.63%
========================================
Files 1733 1733
Lines 197686 197690 +4
Branches 18226 18196 -30
========================================
+ Hits 157418 157422 +4
Misses 40268 40268 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing one bug. Eventually we also need to figure out how to address the other line-number-related issue in #8257.
file_with_no_newline.i | ||
|
||
^file_with_no_newline\.i:[01]:1: error: .*$ | ||
^EXIT=1$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^EXIT=1$ | |
^EXIT=(1|64)$ |
to make MSVC tests pass.
6ee9f5b
to
8a155c4
Compare
The parser sets the line number used for error messages once reaching a newline. This fixes the logic for the case that the input file does not have a newline. This is only visible on .i files, as the preprocessor adds a newline when there isn't one on .c files.
8a155c4
to
a262c00
Compare
The parser sets the line number used for error messages once reaching a newline. This fixes the logic for the case that the input file does not have a newline.
This is only visible on
.i
files, as the preprocessor adds a newline when there isn't one on.c
files.