Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protect ieee_floatt::rounding_mode #8551

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

kroening
Copy link
Member

To ensure complete initialization, the rounding_mode member of ieee_floatt is now protected.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

To ensure complete initialization, the rounding_mode member of ieee_floatt
is now protected.
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.93%. Comparing base (f9a7807) to head (1a1b6ac).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8551      +/-   ##
===========================================
+ Coverage    78.38%   78.93%   +0.55%     
===========================================
  Files         1729     1729              
  Lines       200151   198762    -1389     
  Branches     18244    18313      +69     
===========================================
+ Hits        156883   156888       +5     
+ Misses       43268    41874    -1394     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterschrammel peterschrammel removed their assignment Jan 2, 2025
@kroening kroening merged commit 6dc6dd5 into develop Jan 2, 2025
39 of 41 checks passed
@kroening kroening deleted the ieee_floatt-protect-rounding_mode branch January 2, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants