Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMT2: range_type fixes #8537

Merged
merged 3 commits into from
Feb 4, 2025
Merged

SMT2: range_type fixes #8537

merged 3 commits into from
Feb 4, 2025

Conversation

kroening
Copy link
Member

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 15.21739% with 39 lines in your changes missing coverage. Please review.

Project coverage is 78.91%. Comparing base (f9a7807) to head (632093c).
Report is 105 commits behind head on develop.

Files with missing lines Patch % Lines
src/solvers/smt2/smt2_conv.cpp 18.42% 31 Missing ⚠️
src/util/std_types.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8537      +/-   ##
===========================================
+ Coverage    78.38%   78.91%   +0.53%     
===========================================
  Files         1729     1729              
  Lines       200151   198796    -1355     
  Branches     18244    18357     +113     
===========================================
+ Hits        156883   156885       +2     
+ Misses       43268    41911    -1357     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This fixes the encoding of addition for ranges that do not start from 0.

This fixes the translation from SMT-LIB models into a satisfying assignment
for ranges that do not start from 0.
This adds an implementation of minus on range types to the SMT2 backend.
This implements unary minus on the range type in the SMT2 backend.
@kroening kroening merged commit f2489e3 into develop Feb 4, 2025
38 of 41 checks passed
@kroening kroening deleted the smt2-range-fix branch February 4, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants