Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement xnor in prop_conv_solvert #8533

Merged
merged 1 commit into from
Dec 20, 2024
Merged

implement xnor in prop_conv_solvert #8533

merged 1 commit into from
Dec 20, 2024

Conversation

kroening
Copy link
Member

This adds xnor to prop_conv_solvert, mirroring the implementation for nor/nand.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This adds xnor to prop_conv_solvert, mirroring the implementation for nor/nand.
@kroening kroening marked this pull request as ready for review December 17, 2024 22:45
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.93%. Comparing base (436ed5d) to head (d877a12).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
src/solvers/prop/prop_conv_solver.cpp 71.42% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8533      +/-   ##
===========================================
- Coverage    78.93%   78.93%   -0.01%     
===========================================
  Files         1728     1728              
  Lines       198662   198664       +2     
  Branches     18346    18351       +5     
===========================================
  Hits        156811   156811              
- Misses       41851    41853       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit d5cf498 into develop Dec 20, 2024
37 of 41 checks passed
@tautschnig tautschnig deleted the prop-solve-xnor branch December 20, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants