Remove support for irep_idt-as-std::string #8154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #8040 ensured we were still able to compile the code base with
irep_idt
typedef'd tostd::string
(viaUSE_STD_STRING
), experiments at that time also demonstrated that performance is substantially worse, and not all tests would pass.This commit now removes this untested feature to pave the way for changes that may break
dstringt
tostd::string
compatibility.