Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the invariant message for unimplemented SMT count trailing zeros conversion. #8044

Conversation

thomasspriggs
Copy link
Contributor

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Because this previously yielded a byte swap message which does not match
the kind of expresion which triggers it.
@thomasspriggs thomasspriggs force-pushed the tas/fix_count_trailing_zeros_invariant branch from 55bf8a2 to 7979553 Compare November 17, 2023 13:46
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74075ec) 79.09% compared to head (7979553) 79.09%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8044   +/-   ##
========================================
  Coverage    79.09%   79.09%           
========================================
  Files         1699     1699           
  Lines       196512   196512           
========================================
  Hits        155428   155428           
  Misses       41084    41084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasspriggs thomasspriggs merged commit bf6d759 into diffblue:develop Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants