Replace usage of std::result_of with std::invoke_result
#8037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because infering the return type from the template parameters is a sizeable portion of the function implementation. So using an `auto` type tells the compiler that the type is in the return statement and saves us duplicating the same work in two places.
C++17 deprecates `std::result_of` in favour of `std::invoke_result`. Updating our code to use the replacement avoids the use of the reprecated version.
thomasspriggs
requested review from
kroening,
tautschnig and
peterschrammel
as code owners
esteffin
added
the
Version 6
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8037 +/- ##
========================================
Coverage 79.09% 79.09%
========================================
Files 1699 1699
Lines 196508 196508
========================================
Hits 155430 155430
Misses 41078 41078 ☔ View full report in Codecov by Sentry. |
tautschnig
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++17 deprecates
std::result_ofin favour ofstd::invoke_result. Updating our code to use the replacement avoids the use of the deprecated version.