Refactor smt_function_application_termt::indices using C++17 feature
#8035
+6
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With C++17's `if constexpr` feature we can now remove two alternate function templates and just put the alternate implementations in line. This puts the specialisation into the outer function, so that it is specialised with the correct implementation for the given `functiont`, rather than dispatching based on the `std::true_type` / `std::false_type` overloads.
thomasspriggs
requested review from
peterschrammel,
NlightNFotis,
TGWDB and
esteffin
as code owners
3 tasks
tautschnig
approved these changes
Nov 14, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8035 +/- ##
========================================
Coverage 79.09% 79.10%
========================================
Files 1699 1699
Lines 196508 196505 -3
========================================
+ Hits 155430 155443 +13
+ Misses 41078 41062 -16 ☔ View full report in Codecov by Sentry. |
esteffin
approved these changes
Nov 14, 2023
Comment on lines
+161
to
+164
| if constexpr(has_indicest<functiont>::value) | ||
| return function.indices(); | ||
| else | ||
| return {}; |
There was a problem hiding this comment.
That's the change that I wanted to do had I the time for it 🥇
esteffin
added
the
Version 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With C++17's
if constexprfeature we can now remove two alternate function templates and just put the alternate implementations in line. This puts the specialisation into the outer function, so that it is specialised with the correct implementation for the givenfunctiont, rather than dispatching based on thestd::true_type/std::false_typeoverloads.