Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform simplification of not_exprt as preorder step #7996

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tautschnig
Copy link
Collaborator

Each of the possible simplifications has an impact on its operands, which in turn mostly needs to be simplified. Instead of doing this again (as the operand has already been simplified), do most of the work as a preorder step so that only the modified operand is subject to simplification.

We may wish to merge #6118 first to then use resultt as return types and pass const arguments.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: Patch coverage is 97.22222% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.38%. Comparing base (1ed7b2f) to head (9be04c0).

Files Patch % Lines
src/util/simplify_expr_boolean.cpp 97.05% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7996      +/-   ##
===========================================
- Coverage    78.38%   78.38%   -0.01%     
===========================================
  Files         1720     1720              
  Lines       187982   188030      +48     
  Branches     18474    18457      -17     
===========================================
+ Hits        147346   147383      +37     
- Misses       40636    40647      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening assigned tautschnig and unassigned kroening and peterschrammel Nov 7, 2023
@tautschnig tautschnig force-pushed the simplify-not-preorder branch from 1bd4401 to f5aa4d8 Compare November 8, 2023 12:55
@tautschnig
Copy link
Collaborator Author

I have now rebased this to make good use of simplify_exprt::resultt.

@tautschnig tautschnig force-pushed the simplify-not-preorder branch from f5aa4d8 to a944e52 Compare November 9, 2023 22:17
Each of the possible simplifications has an impact on its operands,
which in turn mostly needs to be simplified. Instead of doing this again
(as the operand has already been simplified), do most of the work as a
preorder step so that only the modified operand is subject to
simplification.
@tautschnig tautschnig force-pushed the simplify-not-preorder branch from f6de15d to 9be04c0 Compare April 23, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants