-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform simplification of not_exprt as preorder step #7996
Open
tautschnig
wants to merge
1
commit into
diffblue:develop
Choose a base branch
from
tautschnig:simplify-not-preorder
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7996 +/- ##
===========================================
- Coverage 78.38% 78.38% -0.01%
===========================================
Files 1720 1720
Lines 187982 188030 +48
Branches 18474 18457 -17
===========================================
+ Hits 147346 147383 +37
- Misses 40636 40647 +11 ☔ View full report in Codecov by Sentry. |
tautschnig
force-pushed
the
simplify-not-preorder
branch
from
November 8, 2023 12:55
1bd4401
to
f5aa4d8
Compare
I have now rebased this to make good use of |
esteffin
reviewed
Nov 9, 2023
tautschnig
force-pushed
the
simplify-not-preorder
branch
from
November 9, 2023 22:17
f5aa4d8
to
a944e52
Compare
esteffin
approved these changes
Nov 9, 2023
5 tasks
tautschnig
force-pushed
the
simplify-not-preorder
branch
from
January 22, 2024 15:06
a944e52
to
f6de15d
Compare
Each of the possible simplifications has an impact on its operands, which in turn mostly needs to be simplified. Instead of doing this again (as the operand has already been simplified), do most of the work as a preorder step so that only the modified operand is subject to simplification.
tautschnig
force-pushed
the
simplify-not-preorder
branch
from
April 23, 2024 08:46
f6de15d
to
9be04c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of the possible simplifications has an impact on its operands, which in turn mostly needs to be simplified. Instead of doing this again (as the operand has already been simplified), do most of the work as a preorder step so that only the modified operand is subject to simplification.
We may wish to merge #6118 first to then use
resultt
as return types and passconst
arguments.