Skip to content

Bump cmake version to 3.8 #7184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

thomasspriggs
Copy link
Contributor

This PR bumps the cmake version to 3.8. Because this is the minimum cmake version which supports a value of 17 for CXX_STANDARD. This enables moving the C++ standard version we use for compiling cbmc to C++17 based on setting this setting rather than setting compiler flags.

See also related PR - #7172

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Because this is the minimum cmake version which supports a value of `17`
for `CXX_STANDARD`. This enables moving the C++ standard version we use
for compiling cbmc to C++17 based on setting this setting rather than
setting compiler flags.
@thomasspriggs thomasspriggs requested a review from a team as a code owner October 4, 2022 13:51
@thomasspriggs thomasspriggs mentioned this pull request Oct 4, 2022
4 tasks
@thomasspriggs
Copy link
Contributor Author

Reference to the cmake documentation for CXX_STANDARD - https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD.html
CMake 3.8 was released in November 2018, so it should be relatively widely available by now - https://github.com/Kitware/CMake/releases/tag/v3.8.0

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 77.82% // Head: 77.89% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (7f86707) compared to base (2a08d59).
Patch coverage: 91.45% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7184      +/-   ##
===========================================
+ Coverage    77.82%   77.89%   +0.07%     
===========================================
  Files         1578     1616      +38     
  Lines       182242   186701    +4459     
===========================================
+ Hits        141824   145433    +3609     
- Misses       40418    41268     +850     
Impacted Files Coverage Δ
src/goto-instrument/contracts/contracts.cpp 95.11% <90.47%> (-1.18%) ⬇️
src/assembler/remove_asm.cpp 78.66% <93.10%> (+27.28%) ⬆️
src/goto-instrument/contracts/contracts.h 100.00% <100.00%> (ø)
src/goto-instrument/nondet_static.cpp 96.92% <100.00%> (ø)
src/goto-programs/string_instrumentation.cpp 25.11% <100.00%> (ø)
src/solvers/smt2/smt2_conv.h 84.61% <0.00%> (-15.39%) ⬇️
src/util/invariant.cpp 72.54% <0.00%> (-7.85%) ⬇️
src/goto-programs/goto_program.h 90.19% <0.00%> (-0.51%) ⬇️
src/cprover/instrument_contracts.cpp 90.51% <0.00%> (ø)
src/cprover/state_encoding_targets.cpp 5.46% <0.00%> (ø)
... and 48 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thomasspriggs thomasspriggs merged commit af8e924 into diffblue:develop Oct 4, 2022
@thomasspriggs thomasspriggs deleted the tas/bump_cmake branch October 4, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants