Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: do not unnecessarily constrain what models solvers can produce [blocks: #6439] #6849

Merged
merged 2 commits into from
May 11, 2022
Merged

Tests: do not unnecessarily constrain what models solvers can produce [blocks: #6439] #6849

merged 2 commits into from
May 11, 2022

Conversation

tautschnig
Copy link
Collaborator

The changes in this PR make regression tests also pass with the models produced by MergeSat (cf. #6439).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

tautschnig added 2 commits May 10, 2022 22:34
@tautschnig
Test: unconstrained pointer need not be dynamic object
7071b89 
Depending on the model returned by the solver, the unconstrained
pointer could fail one of several assertions: it need not be a dynamic
object, and the test specification should accept that.
@tautschnig
JBMC tests: constrain length of non-deterministic input string
ae439ed 
A solver may return a model that results in generating a string that
would exceed available memory.
@tautschnig tautschnig changed the title Tests: do not unnecessarily constrain what models solvers can produce Tests: do not unnecessarily constrain what models solvers can produce [blocks: #6439] May 10, 2022
@tautschnig tautschnig self-assigned this May 10, 2022
@tautschnig tautschnig merged commit 5c974cc into diffblue:develop May 11, 2022
@tautschnig tautschnig deleted the cleanup/solver-indep-tests branch May 11, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroening kroening kroening approved these changes

Assignees

@tautschnig tautschnig

Labels
blocker Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tautschnig @kroening