Avoid duplicate "warning:" or "error:" output #1359

tautschnig · 2017-09-07T15:53:36Z

The gcc message handler already took care of this; make the console message
handler do the same.

kroening · 2017-09-08T05:53:31Z

Uhoh, lots of regressions check for "CONVERSION ERROR". Not clear whether to change the tests or do a special case for that.

tautschnig · 2017-09-08T11:02:37Z

Assigning to myself for further work at a later time. No urgency/dependency here for anyone.

codecov · 2021-01-10T13:48:12Z

Codecov Report

Attention: Patch coverage is 31.50685% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 78.23%. Comparing base (1ed7b2f) to head (613289b).

Files	Patch %	Lines
src/cpp/cpp_typecheck_expr.cpp	16.66%	15 Missing ⚠️
src/goto-cc/ms_cl_mode.cpp	0.00%	5 Missing ⚠️
src/goto-cc/armcc_mode.cpp	0.00%	4 Missing ⚠️
src/ansi-c/c_typecheck_base.cpp	0.00%	3 Missing ⚠️
src/cpp/cpp_typecheck_compound_type.cpp	40.00%	3 Missing ⚠️
src/goto-cc/cw_mode.cpp	0.00%	3 Missing ⚠️
src/goto-programs/builtin_functions.cpp	0.00%	3 Missing ⚠️
src/cpp/cpp_typecheck_resolve.cpp	0.00%	2 Missing ⚠️
src/goto-cc/cl_message_handler.cpp	0.00%	2 Missing ⚠️
src/goto-cc/cl_message_handler.h	0.00%	2 Missing ⚠️
... and 7 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1359      +/-   ##
===========================================
- Coverage    78.38%   78.23%   -0.15%     
===========================================
  Files         1720     1720              
  Lines       187982   188342     +360     
  Branches     18474    18466       -8     
===========================================
+ Hits        147346   147353       +7     
- Misses       40636    40989     +353

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tautschnig · 2021-01-10T21:32:51Z

Uhoh, lots of regressions check for "CONVERSION ERROR". Not clear whether to change the tests or do a special case for that.

I have revamped this PR, and none of the "CONVERSION ERROR" messages should be affected. It's really just to avoid "warning: warning: " being printed to users.

martin-cs

Much respect for resolving a 2017 issue!

TGWDB · 2023-05-03T15:19:38Z

Closing due to age (no further comment on PR content), please reopen with rebase on develop if you intent to continue this work.

tautschnig · 2023-05-04T12:11:08Z

Re-opening: this is just waiting for a review.

TGWDB · 2023-05-10T14:16:58Z

@remi-delmas-3000 @kroening Woulda review be possible?

regression/ansi-c/linking_conflicts1/test.desc

regression/cbmc/incomplete-structs/test.desc

kroening · 2024-04-24T20:20:40Z

src/goto-cc/cl_message_handler.h

+
+  /// With \p yes set to \c true, prefix warnings with an error message.
+  /// \param yes: Whether or not to prefix warnings.
+  void print_warnings_as_errors(bool yes)


Do we really need that?

I'd say it depends on how closely we'd like to mimic the behaviour of Visual Studio and GCC. Prior to this change, we just printed "warning" but nonetheless failed with a non-zero exit code when Werror was used. With this change, we would actually print "error" for such now-fatal warnings, as those compilers do.

Feels a bit cosmetic, but why not.

The gcc and cl message handlers already take care of this, and we had a mix of some messages including the "warning:" or "error:" prefix when others don't.

…y to warning We already did this for GCC, but we can also do this for other modes (ARMCC, CodeWarrior, LD, CL, LINK).

We already treated warnings as errors (if requested via command-line options), but we should also mimic the output presented by CL/GCC with those command-line options set.

tautschnig added the cleanup label Sep 7, 2017

tautschnig self-assigned this Sep 8, 2017

tautschnig added the do not merge label Sep 8, 2017

tautschnig mentioned this pull request Jan 5, 2018

[TG-925] Add command line options for setting up satcheck randomizer #1501

Closed

tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jan 4, 2021

Avoid duplicate warning, merge with diffblue#1359/duplicate-warning

5d1f43b

tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jan 4, 2021

Avoid duplicate warning, merge with diffblue#1359/duplicate-warning

82acac1

tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jan 5, 2021

Avoid duplicate warning, merge with diffblue#1359/duplicate-warning

ea1b285

tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jan 5, 2021

Avoid duplicate warning, merge with diffblue#1359/duplicate-warning

8e4e600

tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jan 6, 2021

Avoid duplicate warning, merge with diffblue#1359/duplicate-warning

489b42d

tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jan 8, 2021

Avoid duplicate warning, merge with diffblue#1359/duplicate-warning

6b66928

tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jan 8, 2021

Avoid duplicate warning, merge with diffblue#1359/duplicate-warning

442fe04

tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jan 8, 2021

Avoid duplicate warning, merge with diffblue#1359/duplicate-warning

100c8ca

tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jan 8, 2021

Avoid duplicate warning, merge with diffblue#1359/duplicate-warning

3684df2

tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jan 8, 2021

Avoid duplicate warning, merge with diffblue#1359/duplicate-warning

7e1ab85

tautschnig force-pushed the duplicate-warning branch from ff8217a to ff59fa7 Compare January 10, 2021 13:09

tautschnig requested review from chrisr-diffblue, kroening, martin-cs, peterschrammel and smowton as code owners January 10, 2021 13:09

tautschnig removed the do not merge label Jan 10, 2021

tautschnig removed their assignment Jan 10, 2021

martin-cs approved these changes Jan 11, 2021

View reviewed changes

peterschrammel approved these changes Jan 14, 2021

View reviewed changes

tautschnig force-pushed the duplicate-warning branch from 220ba7d to 6263492 Compare November 20, 2022 21:46

TGWDB approved these changes Nov 23, 2022

View reviewed changes

tautschnig unassigned nwetzler Dec 16, 2022

tautschnig force-pushed the duplicate-warning branch from 6263492 to 0ef65f8 Compare February 23, 2023 09:50

tautschnig requested a review from remi-delmas-3000 as a code owner February 23, 2023 09:50

TGWDB closed this May 3, 2023

tautschnig reopened this May 4, 2023

tautschnig force-pushed the duplicate-warning branch from 0ef65f8 to d0bc9d3 Compare May 4, 2023 12:11

tautschnig self-assigned this May 31, 2023

tautschnig added the Needs rebase label May 31, 2023

tautschnig force-pushed the duplicate-warning branch from d0bc9d3 to 5af219a Compare June 1, 2023 18:54

tautschnig removed the Needs rebase label Jun 1, 2023

tautschnig removed their assignment Jun 1, 2023

tautschnig force-pushed the duplicate-warning branch from 5af219a to 5b611b2 Compare April 23, 2024 08:50

kroening reviewed Apr 24, 2024

View reviewed changes

regression/ansi-c/linking_conflicts1/test.desc Show resolved Hide resolved

kroening reviewed Apr 24, 2024

View reviewed changes

regression/cbmc/incomplete-structs/test.desc Outdated Show resolved Hide resolved

kroening reviewed Apr 24, 2024

View reviewed changes

tautschnig force-pushed the duplicate-warning branch from 5b611b2 to 0b725d3 Compare April 25, 2024 07:45

tautschnig added 3 commits April 25, 2024 09:02

Avoid duplicate "warning:" or "error:" prefixes in the C/C++ front-end

9659d17

The gcc and cl message handlers already take care of this, and we had a mix of some messages including the "warning:" or "error:" prefix when others don't.

goto-cc modes: interpret command-line options to set default verbosit…

587824f

…y to warning We already did this for GCC, but we can also do this for other modes (ARMCC, CodeWarrior, LD, CL, LINK).

GCC and CL message handler: print warnings as errors

613289b

We already treated warnings as errors (if requested via command-line options), but we should also mimic the output presented by CL/GCC with those command-line options set.

tautschnig force-pushed the duplicate-warning branch from 0b725d3 to 613289b Compare April 25, 2024 09:02

kroening approved these changes Apr 25, 2024

View reviewed changes

kroening merged commit f9f84f3 into diffblue:develop Apr 25, 2024
38 of 40 checks passed

tautschnig deleted the duplicate-warning branch April 26, 2024 08:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid duplicate "warning:" or "error:" output #1359

Avoid duplicate "warning:" or "error:" output #1359

tautschnig commented Sep 7, 2017

kroening commented Sep 8, 2017

tautschnig commented Sep 8, 2017

codecov bot commented Jan 10, 2021 •

edited

Loading

tautschnig commented Jan 10, 2021

martin-cs left a comment

TGWDB commented May 3, 2023

tautschnig commented May 4, 2023

TGWDB commented May 10, 2023

kroening Apr 24, 2024

tautschnig Apr 25, 2024

kroening Apr 25, 2024

Avoid duplicate "warning:" or "error:" output #1359

Avoid duplicate "warning:" or "error:" output #1359

Conversation

tautschnig commented Sep 7, 2017

kroening commented Sep 8, 2017

tautschnig commented Sep 8, 2017

codecov bot commented Jan 10, 2021 • edited Loading

Codecov Report

tautschnig commented Jan 10, 2021

martin-cs left a comment

Choose a reason for hiding this comment

TGWDB commented May 3, 2023

tautschnig commented May 4, 2023

TGWDB commented May 10, 2023

kroening Apr 24, 2024

Choose a reason for hiding this comment

tautschnig Apr 25, 2024

Choose a reason for hiding this comment

kroening Apr 25, 2024

Choose a reason for hiding this comment

codecov bot commented Jan 10, 2021 •

edited

Loading