-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3872 #3877
Fix #3872 #3877
Conversation
This commit changes some `QueryFragment` impls that previously assumed that the provided primary key consist only of a single column. The new implementation allows composite keys as well. In addition I also added two tests to cover these cases as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weiznich, out of curiosity could you elaborate a bit more on the naming of the DoNothingHelper
trait? Functionality wise it looks good to me!
There is no reasoning behind that name at all. I guess my thoughts were something like: It is somehow related to the That written: I'm open to change it to some better fitting name if someone comes up with a suggestion. |
Haha it's true that the name of the trait feels super weird like "wait what we need a trait to help us do nothing?" 😂 |
Right, I didn't notice that the trait name might imply something else 🙈 I've pushed e8bc77a to include now explicitly in the name that it's about the |
This commit changes some
QueryFragment
impls that previously assumed that the provided primary key consist only of a single column. The new implementation allows composite keys as well. In addition I also added two tests to cover these cases as well.