Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing Set up Python step #946

Closed
wants to merge 2 commits into from
Closed

fix: failing Set up Python step #946

wants to merge 2 commits into from

Conversation

hamirmahal
Copy link

fix: failing Set up Python step

Related Issue

This pull request fixes #945.

Motivation and Context

The Set up Python step fails on the main branch. This pull request fixes that by using a different action.

How Has This Been Tested

CI

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have checked that my code does not duplicate functionality elsewhere in Caster.
  • My code implements all the features I wish to merge in this pull request.

Maintainer/Reviewer Checklist

  • Basic functionality has been tested and works as claimed.
  • New documentation is clear and complete.
  • Code is clear and readable.

Copy link
Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Install C++ Compiler for Python 2.7 step, which is the step after Set up Python, still fails.

@LexiconCode
Copy link
Member

LexiconCode commented Mar 31, 2024

Thank you so much for helping out with the project. Sorry I haven't gotten back to you in a more timely manner. My time has been limited and involved upstream in Natlink/NalinkCore

The reason it fails is because of the redistributable isn't available through Microsoft and only retrievable through the way back time machine.

I had a generous individual for a time host the package. Unfortunately the host is no longer available.
https://github.com/dictation-toolbox/Caster/blob/master/.github%2FInstall-VCForPython27.ps1#L49

Since official support has stopped with Python 2.7 I'm inclined to drop the test all together. I would still leave a branch up with 2.7 accessible code but without further support.

If you'd like to contribute further go to 'PyDrop2' branch for most of the recent work is committed. I run into a bit of an issue with QT dropping support for python 32-bit.

If you would like to connect and chat further I'm all for supporting any level of contributing.

@hamirmahal
Copy link
Author

You're welcome!

@hamirmahal
Copy link
Author

I'm spread a bit thin at the moment; I'm not sure if there are any other areas where I can contribute immediately. But, I'll open another pull request if I see something I might be able to improve.

@hamirmahal hamirmahal closed this Mar 31, 2024
@hamirmahal hamirmahal deleted the fix/failing-set-up-python-step branch March 31, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up Python step in Caster Lint/Unit Tests / python 2 windows (2.7.x) (push) fails
2 participants