add eulaw with lime notebook (refs #756) #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…-for-eulaw # Conflicts: # dianna/utils/downloader.py
it may cause the build/install failures that we're having on mac and ubuntu
This was
linked to
issues
Oct 10, 2024
elboyran
reviewed
Oct 11, 2024
| @@ -0,0 +1,1048 @@ | |||
| { | |||
There was a problem hiding this comment.
Would be interesting to show the same sentence in respect to the class "constitutive".
I hope we can address this before we make a video based on the notebook. For now, it's all a very good work and I'd like to merge.
Reply via ReviewNB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still need to add:
As Elena stated in an older comment about this tutorial: