-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overview tutorial and other tutorial changes #776
Conversation
Small addition into the introduction. Attempt to reintroduce the Coffee dataset link.
…dianna into overview_and_tutorials_change
reintroduced the link to the coffee dataset
…orial with the opposite class for the first example and with a second example. It works with special characters now, though slowly.
…orial with the opposite class for the first example and with a second example. It works with special characters now, though slowly.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…xplanaiton sentence.
…planaiton sentence.
…xplanaiton sentence.
…and explainers; fixing Collab and root directory settings; text and image example
… temperature days.
…al; make use of the root directory
Also, please mind the related PR #778! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elboyran thanks, great job in polishing the tutorials and adding fixes 👍 regarding #755, I noticed you added colormap='bwr'
to the neotebooks. Instead, we could fix the default colormap in the function itself, see here, the default colormap is now RdBu
but it can be changed to bwr
. Can you please fix it in the visulaization/text.py
?
The rest of the pull request look good to me.
@SarahAlidoost I thought I changed it first thing, but the installation didn't work (before my other PR fix), so I duplicated it in the notebooks. I will check again. |
Fixing the colormap.
@SarahAlidoost Ah, the change was lost as I had a problem merging with the |
Thanks, one minor thing left, you can now remove |
…dianna into overview_and_tutorials_change
Fixes #732, #755 and #770