Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview tutorial and other tutorial changes #776

Merged
merged 27 commits into from
Jun 5, 2024

Conversation

elboyran
Copy link
Contributor

Fixes #732, #755 and #770

@elboyran elboyran added the documentation Improvements or additions to documentation label May 29, 2024
@elboyran elboyran self-assigned this May 29, 2024
elboyran and others added 4 commits May 29, 2024 15:46
Small addition into the introduction.
Attempt to reintroduce the Coffee dataset link.
reintroduced the link to the coffee dataset
…orial with the opposite class for the first example and with a second example. It works with special characters now, though slowly.
elboyran added 2 commits May 31, 2024 11:40
…orial with the opposite class for the first example and with a second example. It works with special characters now, though slowly.
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@elboyran elboyran marked this pull request as ready for review May 31, 2024 15:28
@elboyran elboyran requested review from cwmeijer and loostrum May 31, 2024 15:29
@elboyran
Copy link
Contributor Author

Also, please mind the related PR #778!

Copy link
Member

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elboyran thanks, great job in polishing the tutorials and adding fixes 👍 regarding #755, I noticed you added colormap='bwr' to the neotebooks. Instead, we could fix the default colormap in the function itself, see here, the default colormap is now RdBu but it can be changed to bwr. Can you please fix it in the visulaization/text.py?

The rest of the pull request look good to me.

@elboyran
Copy link
Contributor Author

elboyran commented Jun 5, 2024

@SarahAlidoost I thought I changed it first thing, but the installation didn't work (before my other PR fix), so I duplicated it in the notebooks. I will check again.

Fixing the colormap.
@elboyran
Copy link
Contributor Author

elboyran commented Jun 5, 2024

@SarahAlidoost Ah, the change was lost as I had a problem merging with the main changes at some point. Added it now, thanks for spotting it!

@elboyran elboyran requested a review from SarahAlidoost June 5, 2024 07:44
@SarahAlidoost
Copy link
Member

@SarahAlidoost Ah, the change was lost as I had a problem merging with the main changes at some point. Added it now, thanks for spotting it!

Thanks, one minor thing left, you can now remove colormap='bwr' from notebooks, no need to re-run the notebooks again. I approve the pull request.

@elboyran elboyran merged commit 20e6127 into main Jun 5, 2024
17 checks passed
@elboyran elboyran deleted the overview_and_tutorials_change branch June 14, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
2 participants