yRCA issue #3 fix #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teto1992
requested changes
Jan 17, 2023
There was a problem hiding this comment.
@LucaRUnipi the case is fine. Please add ASCII sketch in the comment.
LucaRUnipi
commented
Jan 30, 2023
teto1992
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I proposed a new rule for yRCA to successfully identify the case when an instance of service SI doesn't wait enough time for an instance of SJ reply. This specific case has not taken in consideration and yRCA returns a "Found no failure..." which is not the correct explanation.