Skip to content

Commit

Permalink
fix: dependency upgrades and corrected warnings #29 (#30)
Browse files Browse the repository at this point in the history
* fix: dependency upgrades and corrected warnings #29

* fix: upgrade node versions in CI
  • Loading branch information
dhutchison authored Oct 18, 2022
1 parent a760685 commit 9162ce6
Show file tree
Hide file tree
Showing 10 changed files with 8,325 additions and 4,832 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
matrix:
# the Node.js versions to build on
node-version: [12.x]
node-version: [16.x]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
node-version: 16
registry-url: https://registry.npmjs.org/
- run: npm ci
- run: npm run build
Expand Down
10 changes: 7 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ In this plugin you will be able to add your <a href="https://www.ebeco.com" targ

Assuming you have homebridge installed and set up, you can run below command to install this plugin

`npm install -g homebridge-ebeco`
`npm install -g @devwithimagination/homebridge-ebeco`

Then, you can add the platform configuration to your config.json or you can configure it throguh the UI directly.

Expand All @@ -32,7 +32,7 @@ We will need to input your username and password for the Ebeco Connect app that
"platform": "Ebeco",
"name": "Ebeco",
"plugin_map": {
"plugin_name": "homebridge-ebeco"
"plugin_name": "@devwithimagination/homebridge-ebeco"
},
"username": "YOUR EBECO CONNECT USERNAME",
"password": "YOUR EBECO CONNECT PASSWORD"
Expand All @@ -52,5 +52,9 @@ We will need to input your username and password for the Ebeco Connect app that

## Plugin Development

TODO: add in details of how this is developed & tested. Docker-compose file for mocking etc.
The configuration for this plugin includes an extra `apiHost` parameter which can be used to set a different API host from the real one. A `docker-compose.yml` file is included which runs a [WireMock][wiremock] container including mock request/response cycles for the API.



[wiremock]: https://wiremock.org "Flexible API mocking - WireMock"

2 changes: 1 addition & 1 deletion config-sample.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
{
"platform": "Ebeco",
"plugin_map": {
"plugin_name": "homebridge-ebeco"
"plugin_name": "@devwithimagination/homebridge-ebeco"
},
"name": "Ebeco",
"username": "YOUR EBECO CONNECT E-MAIL/USERNAME",
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: "3.8"
services:
wiremock:
image: rodolpheche/wiremock
image: wiremock/wiremock:2.34.0
ports:
- "8080:8080"
volumes:
Expand Down
Loading

0 comments on commit 9162ce6

Please sign in to comment.