fix(calendar): fix minor type issues #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Birkbjo
commented
Aug 28, 2024
components/calendar/types/index.d.ts
Outdated
| @@ -53,8 +58,7 @@ export interface CalendarProps { | |||
| export const Calendar: React.FC<CalendarProps> | |||
|
|
|||
| export type CalendarInputProps = Omit< | |||
| InputFieldProps, | |||
| 'label' | 'type' | 'value' | |||
| InputFieldProps, 'type' | 'value' | |||
There was a problem hiding this comment.
onFocus should technically be omitted because it's overridden, see https://github.com/dhis2/ui/blob/master/components/calendar/src/calendar-input/calendar-input.js#L76 . We should either omit from props here or call it in internal onFocus.
There was a problem hiding this comment.
I think we should call props.onFocus?.(), follow up in another PR.
|
🚀 Deployed on https://pr-1588--dhis2-ui.netlify.app |
kabaros
approved these changes
Aug 28, 2024
Birkbjo
force-pushed
the
fix/calendar-types
branch
from
07944b8
to
c310fbc
Compare
dhis2-bot
added a commit
that referenced
this pull request
Oct 9, 2024
# [10.0.0-alpha.3](v10.0.0-alpha.2...v10.0.0-alpha.3) (2024-10-09) ### Bug Fixes * **calendar:** fix minor type issues ([#1588](#1588)) ([21e60a6](21e60a6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes some minor type issues when working the
CalendarInput.This was previously omitted from types, but we are in fact spreading it as part of rest to input field - which is great.
This was missing in types but is documented in storybook and ui docs.