Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: header bar for global shell [DHIS2-15635] #1454

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

KaiVandivier
Copy link
Contributor

@KaiVandivier KaiVandivier commented Feb 15, 2024

Implements DHIS2-15635

WIP -- More changes may need to follow


Description

  • When in a React Router context, uses client-side routes to apps
  • Fixes App Menu design to be close-able when clicking on an iframe
  • Merge in changes from RTL
  • Redesign "App/Instance" info in profile menu
    • Handle PWA update info
    • Get client app info and add global shell info

Known issues

  • issue

Checklist

  • API docs are generated
  • Tests were added
  • Storybook demos were added

Screenshots

supporting text

Copy link

cypress bot commented Feb 15, 2024

1 failed test on run #3232 ↗︎

1 583 0 0 Flakiness 0

Details:

fix(header-bar): use layer method to close menu on outside click
Project: ui Commit: b9667b309c
Status: Failed Duration: 06:53 💡
Started: Feb 15, 2024 3:47 PM Ended: Feb 15, 2024 3:54 PM
Failed  components/header-bar/src/features/the_headerbar_contains_a_menu_to_all_apps.feature • 1 failed test • e2e

View Output

Test Artifacts
The HeaderBar contains a menu to all apps > The app menu closes when the user clicks outside Screenshots

Review all test suite changes for PR #1454 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant