fix: grey background flashing when loading #3327
Merged
+11
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BRaimbault
changed the title
|
🚀 Deployed on https://pr-3327--dhis2-maps.netlify.app |
edoardo
approved these changes
Sep 12, 2024
dhis2-bot
added a commit
that referenced
this pull request
Sep 13, 2024
## [100.6.7](v100.6.6...v100.6.7) (2024-09-13) ### Bug Fixes * grey background flashing when loading dashboard ([#3327](#3327)) ([76c52d2](76c52d2))
|
🎉 This PR is included in version 100.6.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement DHIS2-18029
Linked analytics PR: dhis2/analytics#1699
Pass
translucent(false) prop to analytics'sCachedDataQueryProvidercomponent for both plugin and main app.The grey background is meant to indicate interaction is not possible while loading, but at this stage there is nothing clickable in the UI of the maps-app.
Before:
After:
