Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new dashboard plugin architecture #3232

Closed
wants to merge 33 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
2131fe0
refactor: use shared dashboard plugin wrapper
edoardo Jun 3, 2024
0d776a5
chore: bump cli-app-scripts and app-runtime dependencies
edoardo Jun 3, 2024
dc26888
chore: use analytics build from d2-ci for testing
edoardo Jul 3, 2024
1a39155
chore: fix dependencies
edoardo Jul 11, 2024
7edef35
chore: run prettier
edoardo Jul 11, 2024
258354c
chore: use latest cli-app-scripts and app-runtime
edoardo Aug 2, 2024
56d3e52
chore: remove old webpack patch
edoardo Aug 7, 2024
2c9733f
chore: update patch for webpack
edoardo Aug 7, 2024
38ecc59
fix: indicate the plugin is for dashboard
edoardo Aug 13, 2024
c80a6ec
Merge remote-tracking branch 'origin/master' into refactor/use-platfo…
edoardo Aug 16, 2024
23591d2
fix: use uppercase for pluginType value
edoardo Aug 16, 2024
0eb0ab7
fix: disable translucent cover, remove unnecessary style
edoardo Aug 19, 2024
4fece4a
Merge remote-tracking branch 'origin/master' into refactor/use-platfo…
edoardo Aug 19, 2024
e904f3b
Merge remote-tracking branch 'origin/master' into refactor/use-platfo…
edoardo Oct 10, 2024
a3eb864
Merge remote-tracking branch 'origin/master' into refactor/use-platfo…
edoardo Oct 30, 2024
f38b20c
chore: use latest analytics build for testing
edoardo Oct 30, 2024
8e8f12b
Merge remote-tracking branch 'origin/master' into refactor/use-platfo…
edoardo Nov 11, 2024
381d4d2
chore: use latest analytics build for testing
edoardo Nov 15, 2024
3487a16
Merge remote-tracking branch 'origin/master' into refactor/use-platfo…
edoardo Nov 15, 2024
64147ae
refactor: remove unnecessary storing of props in local state
edoardo Nov 18, 2024
49fdcd5
Merge branch 'master' into refactor/use-platform-plugin-components
edoardo Nov 18, 2024
78ea2ac
Merge remote-tracking branch 'origin/master' into refactor/use-platfo…
edoardo Dec 4, 2024
5473c4c
Merge branch 'master' into refactor/use-platform-plugin-components
edoardo Dec 6, 2024
b5a8e35
Merge remote-tracking branch 'origin/master' into refactor/use-platfo…
edoardo Dec 11, 2024
1123096
chore: use latest analytics build for testing
edoardo Dec 11, 2024
f7a8eab
chore: update ui dependency
edoardo Dec 16, 2024
197fd7f
chore: use latest analytics build for testing
edoardo Dec 16, 2024
2169a92
chore: upgrade app-runtime and cli-app-scripts
jenniferarnesen Jan 27, 2025
d87e103
chore: remove krakenjs/post-robot
jenniferarnesen Jan 27, 2025
422c366
chore: lock webpack to version with working patch
jenniferarnesen Jan 28, 2025
95992bb
chore: yarn dedupe
jenniferarnesen Jan 28, 2025
0d7b99d
Merge branch 'master' into refactor/use-platform-plugin-components
jenniferarnesen Jan 28, 2025
a9368de
chore: set final test version name
jenniferarnesen Jan 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update patch for webpack
edoardo committed Aug 7, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
commit 2c9733f4b45a2e3371caa258d9e08ea71d1b539e
57 changes: 57 additions & 0 deletions patches/webpack+5.93.0.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
diff --git a/node_modules/webpack/lib/webworker/ImportScriptsChunkLoadingRuntimeModule.js b/node_modules/webpack/lib/webworker/ImportScriptsChunkLoadingRuntimeModule.js
index d290c42..a87b524 100644
--- a/node_modules/webpack/lib/webworker/ImportScriptsChunkLoadingRuntimeModule.js
+++ b/node_modules/webpack/lib/webworker/ImportScriptsChunkLoadingRuntimeModule.js
@@ -92,7 +92,20 @@ class ImportScriptsChunkLoadingRuntimeModule extends RuntimeModule {
const runtimeTemplate = compilation.runtimeTemplate;
const { _withCreateScriptUrl: withCreateScriptUrl } = this;

- return Template.asString([
+ const outputName = compilation.getPath(
+ getChunkFilenameTemplate(chunk, compilation.outputOptions),
+ {
+ chunk,
+ contentHashType: "javascript"
+ }
+ );
+ const rootOutputDir = JSON.stringify(getUndoPath(
+ outputName,
+ compilation.outputOptions.path,
+ true
+ ));
+
+ return Template.asString([
withBaseURI ? this._generateBaseUri(chunk) : "// no baseURI",
"",
"// object to store loaded chunks",
@@ -146,8 +159,8 @@ class ImportScriptsChunkLoadingRuntimeModule extends RuntimeModule {
Template.indent(
`importScripts(${
withCreateScriptUrl
- ? `${RuntimeGlobals.createScriptUrl}(${RuntimeGlobals.publicPath} + ${RuntimeGlobals.getChunkScriptFilename}(chunkId))`
- : `${RuntimeGlobals.publicPath} + ${RuntimeGlobals.getChunkScriptFilename}(chunkId)`
+ ? `${RuntimeGlobals.createScriptUrl}(${rootOutputDir} + ${RuntimeGlobals.getChunkScriptFilename}(chunkId))`
+ : `${rootOutputDir} + ${RuntimeGlobals.getChunkScriptFilename}(chunkId)`
});`
),
"}"
@@ -187,8 +200,8 @@ class ImportScriptsChunkLoadingRuntimeModule extends RuntimeModule {
"// start update chunk loading",
`importScripts(${
withCreateScriptUrl
- ? `${RuntimeGlobals.createScriptUrl}(${RuntimeGlobals.publicPath} + ${RuntimeGlobals.getChunkUpdateScriptFilename}(chunkId))`
- : `${RuntimeGlobals.publicPath} + ${RuntimeGlobals.getChunkUpdateScriptFilename}(chunkId)`
+ ? `${RuntimeGlobals.createScriptUrl}(${rootOutputDir} + ${RuntimeGlobals.getChunkUpdateScriptFilename}(chunkId))`
+ : `${rootOutputDir} + ${RuntimeGlobals.getChunkUpdateScriptFilename}(chunkId)`
});`,
'if(!success) throw new Error("Loading update chunk failed for unknown reason");'
]),
@@ -225,7 +238,7 @@ class ImportScriptsChunkLoadingRuntimeModule extends RuntimeModule {
RuntimeGlobals.hmrDownloadManifest
} = ${runtimeTemplate.basicFunction("", [
'if (typeof fetch === "undefined") throw new Error("No browser support: need fetch API");',
- `return fetch(${RuntimeGlobals.publicPath} + ${
+ `return fetch(${rootOutputDir} + ${
RuntimeGlobals.getUpdateManifestFilename
}()).then(${runtimeTemplate.basicFunction("response", [
"if(response.status === 404) return; // no update available",