fix: deduplicate organisation unit trees [DHIS2-17994] #2995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deduplicates organisation units in the legacy maintenance app. The issue was noticed in the context of merging organisation units (the backend is amending user's organisation units on merge operation, hence see the context of the original ticket: https://dhis2.atlassian.net/browse/DHIS2-17994)
(The deduplication of organisation unit roots will be fixed in our UI Organisation Unit Tree by the following https://dhis2.atlassian.net/jira/software/c/projects/LIBS/issues/LIBS-702; this ticket just pertains to the legacy maintenance app)
Before
After
(i.e.
Split 1
,Split 2
OUs only show up in the actual position ofSierra Leone > Bo > Baoma
, and not also as separate roots)Notes:
Bombali
(which has a descendantBombali Sebora
) and then the next result/root will beBombali Sebora
. I'm not sure this is great UI 🙃, but I think it's better to leave it alone