Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analyticstablehooks): Adds analytics table hooks to the Maintenance app #2930

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

benguaraldi
Copy link
Contributor

@benguaraldi benguaraldi commented Sep 4, 2024

This adds analytics table hooks to the Maintenance app, as requested in DHIS2-13473.

Note that I alphabetized the order of the items in the Other section and moved Predictors to the same section as Indicators, as the section had gotten too long to show all of the items, at least on my screen.

@Birkbjo
Copy link
Member

Birkbjo commented Sep 4, 2024

Thanks a lot for your contributions lately! I will follow up the open PRs shortly, I've been on vacation the last week.

moved Predictors to the same section as Indicators, as the section had gotten too long to show all of the items, at least on my screen.

While I agree predictors could be grouped with "indicators", I don't think we should move stuff around in this app, since it can be confusing for users if the location of the section has suddenly changed.
I took the freedom to push directly to your branch, and move them back, while adding overflow to the sidebar. Would be great if you could test if that works for you!

@benguaraldi
Copy link
Contributor Author

benguaraldi commented Sep 4, 2024

@Birkbjo That's a much better solution! Thank you! I tested it and it looks good to me.

While I was in there, I made a few additional changes.

Copy link
Member

@Birkbjo Birkbjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again!

@Birkbjo Birkbjo merged commit 1b70c09 into master Sep 9, 2024
6 checks passed
@Birkbjo Birkbjo deleted the DHIS2-13473/analytics-table-hooks branch September 9, 2024 11:04
dhis2-bot added a commit that referenced this pull request Sep 9, 2024
## [32.31.9](v32.31.8...v32.31.9) (2024-09-09)

### Bug Fixes

* **analyticstablehooks:** Adds analytics table hooks to the Maintenance app ([#2930](#2930)) ([1b70c09](1b70c09))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 32.31.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants