-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(command palette): grid layout and navigation #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a useGridNavigation hook that returns a 2D grid of optional grid items, and list items. - Track the active item in the component with the current item object - Add a useIsMobile hook to detect small screens - Display a 4 column app grid for large screens, and 2 columns for small screens
KaiVandivier
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🙌
dhis2-bot
added a commit
that referenced
this pull request
Mar 5, 2025
# 1.0.0 (2025-03-05) ### Bug Fixes * classname for headerbar button ([#11](#11)) ([847f1d1](847f1d1)) * correct app-adapter patch ([356b1cf](356b1cf)) * doc title before app loads ([0c649c6](0c649c6)) * generalize profile menu pwa update ([#16](#16)) ([6834276](6834276)) * update UI for correct app links ([9c4ad78](9c4ad78)) * **deps:** latest cli-app-scripts & patch ([66563cc](66563cc)) * **deps:** pwa package patch ([07cc3df](07cc3df)) * **deps:** try to fix @dhis2/pwa patch ([751ec0e](751ec0e)) * **deps:** update @dhis2/app-runtime and patches ([5ed8dbc](5ed8dbc)) * **deps:** update @dhis2/ui and the header-bar patch ([5765a6d](5765a6d)) * **deps:** upgrade @dhis2/cli-app-scrippts, pwa, and their patches ([686200b](686200b)) * **header-bar:** correct hiding styles ([c939b81](c939b81)) * **header-bar:** display name resolution ([906c390](906c390)) * **plugin-loader:** correct source routing ([9e8fcbc](9e8fcbc)) * hide own header bar ([2a6dd94](2a6dd94)) * improve error message ([df19795](df19795)) * improve plugin resetting logic ([59c693c](59c693c)) * patch app adapter for absolute URLs for data service ([f71327a](f71327a)) * rerender plugin component for new sources ([5630b29](5630b29)) * routing to legacy data entry ([8b746f8](8b746f8)) ### Features * add command palette here (more changes coming) ([#6](#6)) ([bfc32c2](bfc32c2)) * add header-bar design changes ([#8](#8)) ([76e3998](76e3998)) * app version in header bar ([#17](#17)) ([3f0db5a](3f0db5a)) * **command palette:** grid layout and navigation ([#7](#7)) ([a077caa](a077caa)) * improved routing and styles ([#4](#4)) ([e57c4ac](e57c4ac)) * patch @dhis2/app-service-plugin for flexible sizing and onLoad handler ([9b0fdad](9b0fdad)) * patch header bar for routing and app-menu closing fix ([6a336d4](6a336d4)) * pwa and updates for global shell ([455f756](455f756)) * pwa-update prototype ([1d9c8d3](1d9c8d3)) * routing, remove chaff, hide header bar in legacy client apps ([bab5228](bab5228)) * test pluginified app entrypoint by default and fall back to app root ([b997729](b997729)) * use client app name in header bar ([635511c](635511c)) * watch for pwa updates in plugin ([#5](#5)) ([fcbe234](fcbe234))
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: PR-1675