-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: kotlin multi-platform [DHIS2-16221] #116
Conversation
Created the KMP structure. The version has been set to The github action is configured to push a SNAPSHOT version on each PR. Publication to Maven Central has been disabled to avoid accidental publications during the refactor. All the classes have added to Pending Java classes to remove:
|
* refactor: Clean up description call to rule engine * refactor: Clean up evaluation call to rule engine * refactor: Clean up evaluation call to rule engine * refactor: EventDate changed from LocalDate to Instant * Refactor package structure * Refactor package structure * Fix RuleAction interface * Fix RuleAction interface * Fix RuleEngine API interface * Make engine package internal * Make rule engine getInstance static for Java * Update build.gradle.kts
@AutoValue
withrecord
s (andinterface
s for hierarchies)java.time
@Nullable
with@CheckForNull
and removes javax dependencyStringUtils.isEmpty
with plain java and removes common lang dependencyArrays.asList
withList.of
Any failing test that would only check that a factory method did throw a NPE for non-null arguments were removed as in kotlin we will have non-null types for these so no check or test is needed. The existing tests mainly confirmed a behaviour of
@AutoValue
that would generate null checks in the constructor for fields annotated with@Nonnull
.