DHIS-16705 Fix handling of NV filter clause #19758
Conversation
luciano-fiandesio
commented
Jan 23, 2025
luciano-fiandesio
commented
- Fix reference to table alias in PI CTE
- Fix quoting of sort order column
luciano-fiandesio
requested review from
gnespolino,
maikelarabori and
larshelge
| operator = "is not"; | ||
| } else { | ||
| throw new IllegalQueryException( | ||
| ErrorCode.E3000, |
There was a problem hiding this comment.
we should use a dedicated error code
There was a problem hiding this comment.
Argh, you are right, fixing it
| String operator = "NULL".equals(value) ? "is" : filter.getSqlOperator(); | ||
| String operator = filter.getSqlOperator(); | ||
|
|
||
| if (value.trim().equalsIgnoreCase("null")) { |
There was a problem hiding this comment.
I think we could find a way to make this a bit more compact/encapsulated. We could move "null" to a constant.
There was a problem hiding this comment.
Agreed, I can refactor it to be more compact and readable. Do we have constants for null somewhere? I am sure there must be but hard to find the constant
There was a problem hiding this comment.
Great. Right. I guess there is AnalyticsConstants where we could add it.
| if (value.trim().equalsIgnoreCase("null")) { | ||
| if (filter.getOperator() == QueryOperator.EQ || filter.getOperator() == QueryOperator.IEQ) { | ||
| operator = "is"; | ||
| } else if (filter.getOperator() == QueryOperator.NEQ |
There was a problem hiding this comment.
There is now a method in master isNotEqualTo() for QueryOperator which we can use here.
- Fix reference to table alias in PI CTE - Fix quoting of sort order column
luciano-fiandesio
force-pushed
the
DHIS-16705_FIX_FILTERING
branch
from
88fac45 to
e742a28
Compare
|
luciano-fiandesio
added
run-api-analytics-tests
