-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use org unit stored path [DHIS2-18234] #19626
Open
larshelge
wants to merge
37
commits into
master
Choose a base branch
from
org-unit-persisted-path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+101
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larshelge
changed the title
WIP: fix: Org unit persisted path
WIP: fix: Use org unit stored path [DHIS2-18234]
Jan 9, 2025
larshelge
changed the title
WIP: fix: Use org unit stored path [DHIS2-18234]
fix: Use org unit stored path [DHIS2-18234]
Jan 9, 2025
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new method
getStoredPath()
onOrganisationUnit
.Note that the
path
property is mapped with the "property access" mode in Hibernate. Per the Hibernate docs:This means that Hibernate will call
getPath()
and set thepath
property as part of all persistence operations. This in turn means that we don't have to recalculate the path value in the DHIS 2 application every time we need the value, as it will be persisted in the database.The exception is when code modifies the ancestors/parents and relies on an up-to-date path value. Though in those special cases, one can simply call the
getPath()
method. In all other scenarios, thegetStoredPath()
method can be called, which should introduce a significant performance gain.For the
getStoredPath()
method, if the path is not defined, typically as part of an integration test where the state is not yet flushed to the database, the calculated path based on the org unit ancestors is returned.Reducing the pressure from re-calculating the path may alleviate the problem of DHIS2-18234 where the UID of the ancestor org units are not reflecting the persisted value.