Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user query parameter must include username [DHIS2-18748] #19611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbee
Copy link
Contributor

@jbee jbee commented Jan 7, 2025

Summary

When using the query parameter with User this should not run the standard implementation.
Therefore query needs to be considered a "special filter" and excluded for users.

This got overlooked when reworking the special filters in #19046 since the query parameter basically has a name clash.

Manual Testing

Using it to find system user by username once with other special filters and once without

  • /api/users?userOrgUnits=true&includeChildren=true&query=system
  • /api/users?query=system
  • check both URLs result in a list containing the system user (in SL this is the only match)

@jbee jbee self-assigned this Jan 7, 2025
Copy link

sonarqubecloud bot commented Jan 7, 2025

Copy link
Contributor

@david-mackessy david-mackessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a test be added for this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants