fix: user query parameter must include username [DHIS2-18748] #19611
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using the
query
parameter withUser
this should not run the standard implementation.Therefore
query
needs to be considered a "special filter" and excluded for users.This got overlooked when reworking the special filters in #19046 since the
query
parameter basically has a name clash.Manual Testing
Using it to find
system
user byusername
once with other special filters and once without/api/users?userOrgUnits=true&includeChildren=true&query=system
/api/users?query=system