fix: mandatory attributes cannot have empty value [DHIS2-18365] #19586
+87
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
netroms
approved these changes
Jan 6, 2025
david-mackessy
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The main issue was that an empty string value was considered as being present.
Secondary issue was that the attribute value parsing in 2.42 did not accept any other JSON values than a JSON string.
While this is strictly correct the app apparently does use JSON boolean so the parsing was adjusted to handle other JSON types.
For better visibility in case of errors the
JobProgresstracking for synchronous metadata imports was changed to useRecordingJobProgress.transitorywhich behaves like a persistent tracking except that it discards completed nodes in the progress tree.Manual Testing
See Jira description
Automatic Testing
2 new test scenarios where added testing that adding a user either with an empty value for the mandatory attribute or entirely without the attribute results in a CONFLICT response.