fix: message conversation list based on user messages [DHIS2-18605] #19427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vietnguyen
approved these changes
Dec 10, 2024
netroms
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous refactoring in #19046 I missed that
MessageService#getMessageConversations()did not return all messages but just the current user's conversations. So this list needs to be the stating point.But there is an exception to that. When
query=was used the starting point are all conversations matching the query. This can be combined withfilterbut not withqueryStringandqueryOperatorwhich are a different kind of "fuzzy" search for the user's conversions (which also can be combined withfilter).