Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add /tracker/events?categoryOptionComboIdScheme DHIS2-14968 #19102

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

teleivo
Copy link
Contributor

@teleivo teleivo commented Nov 8, 2024

building on #19039

support /tracker/events?categoryOptionComboIdScheme

This does not yet deal with the default category option combo in any special way. Default category option combos are automatically created by DHIS2 itself. They don't have attributeValues and users can also not add any.

This means that we will have to either

  • treat them as not having the requested idScheme as part of the error handling we will soon add
  • or create an exception and for example show their metadata attribute values as default

@teleivo teleivo force-pushed the DHIS2-14968-aoc branch 2 times, most recently from 38b035b to d76c118 Compare November 8, 2024 09:37
@teleivo teleivo marked this pull request as ready for review November 8, 2024 09:50
@teleivo teleivo requested a review from a team as a code owner November 8, 2024 09:50
@teleivo teleivo force-pushed the DHIS2-14968-aoc branch 2 times, most recently from 1cb3306 to eea3fab Compare November 8, 2024 11:29
@teleivo teleivo requested a review from a team November 10, 2024 13:01
@teleivo teleivo enabled auto-merge (squash) November 11, 2024 04:27
Copy link

@teleivo teleivo merged commit da859c7 into master Nov 11, 2024
15 checks passed
@teleivo teleivo deleted the DHIS2-14968-aoc branch November 11, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants