Skip to content

Commit

Permalink
feat: Add skipAnalytics to ProgramTrackedEntityAttribute [DHIS2-16454] (
Browse files Browse the repository at this point in the history
  • Loading branch information
zubaira authored Nov 8, 2024
1 parent b172a26 commit c8725d9
Show file tree
Hide file tree
Showing 4 changed files with 42 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ public class ProgramTrackedEntityAttribute extends BaseIdentifiableObject

private Boolean searchable = false;

private boolean skipIndividualAnalytics;

// -------------------------------------------------------------------------
// Constructors
// -------------------------------------------------------------------------
Expand Down Expand Up @@ -265,6 +267,16 @@ public DeviceRenderTypeMap<ValueTypeRenderingObject> getRenderType() {
return renderType;
}

@JsonProperty
@JacksonXmlProperty(namespace = DxfNamespaces.DXF_2_0)
public boolean isSkipIndividualAnalytics() {
return skipIndividualAnalytics;
}

public void setSkipIndividualAnalytics(boolean skipIndividualAnalytics) {
this.skipIndividualAnalytics = skipIndividualAnalytics;
}

public void setRenderType(DeviceRenderTypeMap<ValueTypeRenderingObject> renderType) {
this.renderType = renderType;
}
Expand Down Expand Up @@ -295,5 +307,6 @@ private static void setShallowCopyValues(
copy.setSharing(original.getSharing());
copy.setSortOrder(original.getSortOrder());
copy.setTranslations(original.getTranslations());
copy.setSkipIndividualAnalytics(original.isSkipIndividualAnalytics());
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@

import static org.hisp.dhis.program.ProgramTest.getNewProgram;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertNotSame;

Expand Down Expand Up @@ -62,6 +63,27 @@ void testCopyOf() {
assertEquals("Copy of Program Name tracked entity attr 1", copy.getName());
}

@Test
void testDefaultSkipAnalyticsValue() {
ProgramTrackedEntityAttribute ptea = new ProgramTrackedEntityAttribute();
assertFalse(
ptea.isSkipIndividualAnalytics(),
"Default value of skipIndividualAnalytics should be false");
}

@Test
void testCopyOfWithSkipAnalytics() {
ProgramTrackedEntityAttribute original = getNewProgramAttribute(getNewProgram());
original.setSkipIndividualAnalytics(true); // Set to true to check copy behavior
ProgramTrackedEntityAttribute copy =
ProgramTrackedEntityAttribute.copyOf.apply(original, getNewProgram());

assertEquals(
original.isSkipIndividualAnalytics(),
copy.isSkipIndividualAnalytics(),
"skipIndividualAnalytics should be copied correctly");
}

private ProgramTrackedEntityAttribute getNewProgramAttribute(Program program) {
ProgramTrackedEntityAttribute ptea = new ProgramTrackedEntityAttribute();
TrackedEntityAttribute tea = new TrackedEntityAttribute();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@

<property name="searchable" column="searchable" />

</class>
<property name="skipIndividualAnalytics" column="skipIndividualAnalytics" />

</class>

</hibernate-mapping>
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

-- Add the new column with a default value of false
ALTER TABLE program_attributes
ADD COLUMN IF NOT EXISTS skipIndividualAnalytics boolean DEFAULT FALSE;

0 comments on commit c8725d9

Please sign in to comment.