fix: [DHIS2-18571] add explicit pageSize=100 to fetch all enrollments #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikmv
reviewed
Jan 20, 2025
|
Hi @eirikhaugstulen. The same issue is happening when bulk-completing events, does it make sense to solve it in PR as well? |
|
@simonadomnisoru Thanks! Updated now! |
|
simonadomnisoru
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the enrollment completion modal was showing incorrect counts due to API pagination limits. The fix adds an explicit pageSize=100 parameter to the API request to ensure all enrollments are fetched.
Changes:
Added pageSize=100 parameter to the tracker/trackedEntities API request in useCompleteBulkEnrollments.js