Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DHIS2-18325] Show orgunit selector in the new event form #3879

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Nov 11, 2024

DHIS2-18325

  • Integrated an organisational unit selector within the Report tab.

  • Made the organisational unit field mandatory and implemented validation within the form.

  • Blocked changes to the organisational unit field in the context selector on the "New Event" page by setting the new isReadOnly property to true.

  • Enabled automatic selection of the organisational unit in the "New Event" form when an organisational unit is selected in the context selector.

  • Removed Cypress tests for clearing the organisational unit on the "New Event" page since this action is now blocked.

  • The rules engine was managed by @JoakimSM.

@henrikmv henrikmv marked this pull request as ready for review December 10, 2024 16:58
@henrikmv henrikmv requested a review from a team as a code owner December 10, 2024 16:58
@henrikmv henrikmv added testing and removed testing labels Dec 10, 2024
Copy link

github-actions bot commented Dec 11, 2024

@henrikmv henrikmv marked this pull request as draft December 11, 2024 11:48
@henrikmv henrikmv removed the testing label Dec 11, 2024
@henrikmv henrikmv added testing and removed testing labels Dec 12, 2024
@henrikmv henrikmv marked this pull request as ready for review December 12, 2024 10:32
@henrikmv henrikmv added testing and removed testing labels Dec 14, 2024
@henrikmv henrikmv added testing and removed testing labels Dec 23, 2024
@JoakimSM JoakimSM force-pushed the hv/feat/DHIS2-18325_showOrgUnitSelectorInNewEventForm branch from b0eea46 to a4bf697 Compare January 20, 2025 15:15
@henrikmv henrikmv added e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud testing and removed testing labels Jan 21, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants